cybai (Haku)
cybai (Haku)
> > Adding `NonEmptySet` type > > @CYBAI what's the definition of the `NonEmptySet` type? Hi @gcanti ! I would expect a `NonEmptySet` will always at least hold **one** item...
@bors-servo try=wpt
Looks like we got a bunch of CRASH; I guess there must be something wrong for the update of `PropertyDescriptor` 🤔
@bors-servo try=wpt
Looks like there are still something wrong for PropertyDescriptor. Let me find out where I should fix it. ``` ▶ ERROR [expected OK] b'/_webgl/conformance/ogles/GL/functions/functions_121_to_126.html' │ → setting getter-only property "display"...
~~With running this test, I can see crashes from the proxy hooks~~ I realized that I ran the test with a wrong build so the Range-detach actually pass with 0fe11a9...
@bors-servo try=wpt
@jdm @emilio (cc @sagudev) is it correct for me to see `ForwardingProxyHandler` in Gecko as our `windowproxy.rs` in Servo? I'm wondering if it's correct to read through the handler functions...
@sagudev I didn't have too much time to dive into it yet :( but I've noticed some code was wrongly patched so I've corrected them and pushed again.
I was wondering if it can be related to `fill_property_descriptor` in `proxyhandler.rs` https://github.com/servo/servo/blob/147a2b65de613beefc9bcd325f6ee69e2656943c/components/script/dom/bindings/proxyhandler.rs#L207-L209 but the test case, `tests/wpt/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity.html`, still failed with readonly `window.inlineRun`; even I pass `true` directly to `writable`...