CPerezz
CPerezz
### Describe the Bug Execution of `.check`, `.build` & `.test` fails due to a compilation problem. I commented out the `i686-pc-windows-gnu` target-related checks since I can't run them in my...
We usually store multiple `Evaluations` inside the same structure (`ProverKey` is an example of that). It's really sub-optimal to store the same `EvaluationDomain` across all of the `Evaluations` of the...
We have an excessive usage of `for _ in ..` which doesn't take profit of the `Iterator` benefits such as the autovectorization. Specially, there were included several `for` loops in...
In the current `Composer` API that we publicly expose, we have a lot of `gate-functions` that require the user to input +6 or +7 fields. As mentioned by @ZER0 and...
We have places in our code where the `Variable` type holds a value that can be mapped securely to a `JubJubScalar`. See for example: https://github.com/dusk-network/plonk/blob/master/src/constraint_system/ecc/scalar_mul/variable_base/mod.rs#L11-L34 Therefore it's important to be...
All true rust types know their size and alignment, which `dyn Trait` types accomplish using their vtable. In consequence, one could build a `TinyBox` type that allocated when `size_of_val(&T) >...
After we started to release new versions of this crate. The `examples` folder was removed since we weren't able to keep it up to date due to the refactors we...
Associated trait-constants are a problem when we need to return from functions things like `& impl Circuit`. Since the trait is not object safe anc we cannot make use of...
It would be nice to avoid having the `Vec` inside of the `Polynomial` struct as `pub` and instead having it private and implement `Iter` and `IntoIter` traits for it.
In Halo2 we have a fantastic tool for circuit-debugging purposes. The `MockProver`. It basically allows to check all the gate-constraints and Lookup errors returning a really accurated description of the...