Hao Geng
Hao Geng
Hi @sankalpwako , the description is a bit confusing and seems to be incomplete. I tried to better formatted the description. Meanwhile would you mind to add more clarification to...
It looks like when "populateClusterCapacity" is called, it only adds the live nodes to cluster model. Maybe we should also add dead nodes there. E.g. ``` cluster.nodes() ``` Only returns...
Upon further investigation, I have more interesting findings. The cluster instance is like a snapshot of the Kafka broker metadata cache: https://github.com/linkedin/kafka/blob/be6e2c520aafe54b07aab9cc5d6ba00503241c9a/clients/src/main/java/org/apache/kafka/clients/Metadata.java#L126 The cached values in metadata cache originally come...
Hi @jlei-nr, thanks for the proposal. Reading through the PR description, I can understand your point of adding this goal. From my understanding, there are 2 reasons that you wanted...
@wyuka @efeg Any last minute comments? If not, I'll merge this PR.
@amuraru Sure, this seems to be a request from multiple cc users. I'll take some time to get the context and review the latest update. Meanwhile, @wyuka please feel free...
Took a first pass and left some comments. Besides, I have some general comments for the commits so far: 1. From my understand, the only difference between the intraBrokerGoalViolation and...
@viktorsomogyi is that ok if we close this PR as you're splitting it into smaller ones?
I don't have much context on this repo. @mitchhh22 could you or your team help to review this?
Hi @tomncooper, thanks for making the change. As we internally hasn't update to that kafka version, we may want to keep extra caution and probably pend this PR until we...