Christopher Higgins

Results 18 comments of Christopher Higgins

This is still an issue. Additionally, when using the `createColumnHelper`, it will not accept string numbers like `"0"`; it only allows for actual numbers, which do not work.

This is still an issue. Simply by importing this component the entire site is forced into Zenscroll behavior, which is just absurd. This needs to be disabled by default. It...

> > vite.config.ts is bundled by vite with esbuild. so that config is used. > > It was my first assumption as well since `tsconfig.node.json` only includes `vite.config.ts`. However, you...

Indeed, when I modify this line to instead pass the targets instead of this hard-coded target, things work as expected https://github.com/vitejs/vite/blob/21ae3716927ed8c466235bdd667a45c26468c8c0/packages/plugin-legacy/src/index.ts#L387 `await detectPolyfills(raw, options.targets, modernPolyfills);`

> `targets` is the legacy target, so I don't think `await detectPolyfills(raw, options.targets, modernPolyfills);` is correct? Maybe we can introduce a new `modernTargets` option. Until there's a way for us...

I forgot to add the version. This is with AppleSkin` 2.4.1+mc1.19` and SoF `1.6.0-beta.4+1.19.2` on MC 1.19.2

If this was fixed in 2.4.4, could you backport the fix to 1.19.2? 2.4.4 is listed as 1.19.4 only.

Appears to be fixed in latest versions

What is the simplest way to consume this code manually, until (if ever) it gets merged?