Srini Muthu comments

Results 10 comments of


                                            Srini Muthu

`swift_version` in the Podspec isn't reflected in the generated Xcode project(s)

I apologize, the setting actually comes from our plugins.

`swift_version` in the Podspec isn't reflected in the generated Xcode project(s)

Actually, I take that back. I ran `pod gen` and the Swift version is definitely set to 4.0 before our plugins do anything: ``` smuthu in ~/Sandbox/ios-video-player on branch master...

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails

> I think we likely want to keep the check for compatibility with other public specs repos on GitHub, and maybe have a more robust fallback when that request 4xxs...

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails

> This seems weird to change for the base class of `source.rb` which calls: > > ```ruby > def update(show_output) > return [] if unchanged_github_repo? > prev_commit_hash = git_commit_hash >...

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails

> maybe have a more robust fallback when that request 4xxs ? @segiddins That works too. Now that you mention it, instead of raising an exception, we could simply log...

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails

@segiddins Let me know if this fallback works.

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails

> Only thing that stands out to me is being a bit less permissive: can we allow 4xxs through, but continue to raise an exception on other errors? @segiddins I...

Github.modified_since_commit shouldn't raise an exception if /GET to api.github.com fails

@segiddins Just following up this, do you have any ideas as to how I can guard against a timeout?

Library fails with Nix ≥ 2.19 due to null bytes in table.nix

Also see https://github.com/NixOS/nix/pull/12024

Writing resolved Go modules as K:V JSON for external bookkeeping

Sounds good @fmeum , started https://github.com/bazelbuild/bazel-gazelle/discussions/1918