Ryan Williams

Results 33 comments of Ryan Williams

I'm not entirely sure "recenterViewscreen" uses "report_zoom_type", but it's the closest enum I could find that makes sense. From what I can tell, zoom_type1 and zoom_type2 in reports are always...

> Overall, code looks good. Thanks for getting that submodule thing figured out! > > I'd be a lot more comfortable with this if it had some fortress-mode unit tests...

Do we have a special region1 save for doing tests on? I see ``test_save.tgz`` mentioned in build logs.

Thanks. Looks like a 1x1 embark, which might be inadequate for testing viewport scrolling.

> > > Can you provide the location of the function in question? I'd like to look at it myself. For Windows DF 0.47.05 64-bit, the masterwork loss constructor is...

Do we have the means to detect reports or messages before they print?

We could just write to DF's gamelog and have SoundSense configured to ignore combat stuff that we don't print. However, that would add a bunch of bloat to the gamelog...

> Sorry for the long delay! FYI, I never made any progress on the unit tests. I went on hiatus due to selling house and moving out of state.

Just stumbled across this after preparing some changes to the variable names, since I've finished cleaning up the whole reverse engineered function to something readable. I can confirm via the...

Does something happen when you click on a hyperlink? In your example, "Skincrafts" is just plain text with an index of -1, so you might have to manually create an...