Bruce Hopkins
Bruce Hopkins
Thanks! I'll get started on it.
@DiegoRBaquero I'm currently working on the PR to implement more docs but I'm not sure which methods I should document, I noticed a common pattern in the codebase. Many of...
The PR opened should fix the issue, but it changes the way the increment works. I'm thinking about making this another command, but I don't know what that would look...
> I think it'd be better to add this functionality into a seperate command, the default behaviour shouldn't be changed for a normal increment, as there a legitimate usecases for...
@CBenoit I've changed the keymappings to be alt+ctrl is this good to be merged?
> Is C-A (ctrl + shift) and C-X already reserved / taken? Because i think they'd make more sense... I've tried those keymaps but for some reason, they don't work....
> I don't think we implement the `#` special register from Kakoune yet (https://github.com/mawww/kakoune/blob/master/doc/pages/registers.asciidoc#special-registers) but `"#` and `#` could be an nice way to do this without needing to add...
> I think it would be ok to kind of hack it in this PR: in `increment_impl` check the `cx.register` to see if it's `'#'` and if it is then...
@the-mikedavis How does it look now?
Thanks for the reply! > Performance optimizations only make sense when you can benchmark the change beforehand and determine that there's a meaningful difference by the optimization I can agree...