Results 25 comments of Brandon Copley

Is this really blocking? Blocked for 2849.4091750030516ms, operation started here: [ ' at process.nextTick (internal/process/next_tick.js:270:7)', ' at handleOperationCallback (/Users/brandoncopley/github/project/node_modules/mongodb-core/lib/connection/pool.js:531:24)', ' at /Users/brandoncopley/github/project/node_modules/mongodb-core/lib/connection/pool.js:597:9', ' at authenticateStragglers (/Users/brandoncopley/github/project/node_modules/mongodb-core/lib/connection/pool.js:504:16)', ' at Connection.messageHandler (/Users/brandoncopley/github/project/node_modules/mongodb-core/lib/connection/pool.js:540:5)',...

Here's the problem: when you run the code "generateSecret()" and pass in an "issuer" as part of the options, the issuer gets dropped due to the following lines: Line 474...

Ahh, this fix appears to already exist in the current branch - what can we do to get this pushed up to NPM?

let user = new AdwordsUser({...}); let campaignService = user.getService('OfflineConversionFeedService', 'v201806')

That gets me started. thanks.

Hey there, For some reason I'm having a really hard time following both your docs and googles docs on tracking offline conversions via the adwords api: "Uploading offline conversions" https://developers.google.com/adwords/api/docs/guides/conversion-tracking...

It's because there was a bug that uses sha1 in that version, even though you thought it was defaulting to sha256. It's a silly error, and I am working on...

``` UserSchema.plugin(passportLocalMongoose, { iterations: 5000, digestAlgorithm: 'sha1' }); ``` Should work.

@saintedlama option 1 is what @toddbluhm has an existing pull request for. I think that's great, but I personally am a bigger proponent of option 2 because it eliminates work...

@toddbluhm Agreed, tracking old/new docs sounds good initially, but more complex than it should be. It's night in Austria now, but hopefully we hear from @saintedlama soon with what he...