Balázs Vajner

Results 20 comments of Balázs Vajner

I have resolved conflicts. However, when running the tests locally I saw `KotlinCodeGenTest` failing with errors like this one: ``` error: unresolved reference: fasterxml import com.fasterxml.jackson.`annotation`.JsonProperty ^ error: cannot access...

I rebased and resolved the conflicts. The aforementioned error still occurs on my machine (asl on master), but the CI build job ran successfully (on my forked repo at least)....

Btw. This PR should also address issue https://github.com/Netflix/dgs-codegen/issues/323

This is an updated version of my previously closed MR on the same topic (https://github.com/Netflix/conductor/pull/3233). I have updated it to the latest version of GraalVM. Otherwise there is no substantial...

Alternatively, since the script engine is selected at runtime, if Nashorn engine could not be retrieved (i. e. Conductor runs on a JDK where it is already removed, and not...

I ran spotlessApply, it seems there were indeed some minor things like import ordering. Spotless check should now pass.

If it causes backward compatibility issues, I would certainly not just replace it (as it would be essentially a breaking change). In this case I think that the feature flag...

As for `inline` task and `switch` operator: > evaluatorType > Type of the evaluator. Supported evaluators: `value-param`, `javascript` which evaluates javascript expression. This could be easily extended with `javascript-graalvm` whilst...

> how about we introduce a new evaluator type graaljs and if specified will use graal to evaluate the script. > This will ensure existing javsascript continues to work and...

> This PR is stale, because it has been open for 45 days with no activity. Remove the stale label or comment, or this will be closed in 7 days....