Blake Williams

Results 54 comments of Blake Williams

@Aneurysm9 That's a good question. I took a look at using `SpanProcessor` but couldn't see how it could be composed with the `batchSpanProcessor` that we're currently using.

> I'm not sure it would work for this use, though, since `OnEnd` receives a `ReadOnlySpan`. It could filter out spans entirely, but not remove certain attributes without some gymnastics...

I ran into this too. I didn't have time to attempt fixing the issue, but it looks like the source of the problem is around this area: https://github.com/folke/which-key.nvim/blob/bd4411a2ed4dd8bb69c125e339d837028a6eea71/lua/which-key/keys.lua#L104 It looks...

> Why not https://github.com/rack/rack/blob/master/lib/rack/events.rb instead? I didn't get to dive too deeply into why, but the [`on_finish`](https://github.com/rack/rack/blob/master/lib/rack/events.rb#L35-L40) event was firing while the request/response was still open and was preventing the...

The use-case at the moment is for deferring non-critical work done in a request/response to happen after a user has already received the response. This primarily includes work that can't...

> If this is what you need, then the callback being defined in the Webserver already makes sense, and shouldn't be ported here IMO. Apologies, but I'm not sure I...

> I understood, I'm just challenging why this should be specced. First, after_reply is too broad. What is a reply, a response? Then the events middleware should be what you...

> @BlakeWilliams do you want to have a go at cutting the spec for this? Update `lib/rack/lint.rb` Definitely, I'll make some time to work on that.

Just opened up a draft PR that has a few open questions here: https://github.com/rack/rack/pull/1802

`Rack::Lint` seems to validate that middleware implements the spec correctly but `rack.response_finished` is completely dependent on the server implementation. Is there a standard way to validate that a server implements...