Egor
Egor
Thank you for the comment! I'll add tests after tablib merge
Hi, Matthew Thank you for your view. I am totally fine with rejecting this functionality to be merged. Your argument about API breaking sounds valuable for me. Your solution to...
The number of affected lines can be more, it's necessary to check all other files, too
Additional affected lines, in [storage.py](https://github.com/aiogram/aiogram/blob/dev-2.x/aiogram/dispatcher/storage.py): https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L41-L43 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L63-L66 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L80-L83 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L97-L100 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L113-L116 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L129-L133 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L150-L152 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L165-L168 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L186-L188 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L204-L207 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L221-L224 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L237-L241 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L258-L260 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L275-L277 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L295 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L298 https://github.com/aiogram/aiogram/blob/01f075d905798c8dde04e9ba86a9bb6917ba9e9a/aiogram/dispatcher/storage.py#L301 And a couple one after the last 2...
Example of implementing this issue might be found [here](https://github.com/aiogram/aiogram/blob/81b36bd19249dbb0d4eb8a0df8e7d5fb0ad16ae4/aiogram/dispatcher/dispatcher.py#L1034). The task is to use the same approach to all other places with the usage of `user` and `chat` as arguments...
@JrooTJunior might be a good idea to use `chat_id` and `user_id` argument naming in `3.0` version from scratch, to avoid occurrence of this issue
Hi @tohabyuraev. Thank you for your interest! This issue affects all the modules in the framework, including `dispatcher.py` and `storage.py`. I am not sure whether there is an effective technique...
I'll remove label `breaking`, as this PR is meant to be a non-breaking refactoring for version 2 of the framework
> @Birdi7 Question for `aiogram.utils.exceptions.Throttled`. It seems that there will not be a mistake without decorator. Just leave it as it
For me the PR looks ok, Alex will check on his own On Sun, Jul 12, 2020, 16:26 Anthony Byuraev wrote: > @Birdi7 @JrooTJunior > Are there any comments? >...