Bilka comments

Results 11 comments of


                                            Bilka

spidertron-remotes aren't checked as "items" so a recipe result (and more) may fail to find one

Another possible solution: Use the new [defines.prototypes](https://lua-api.factorio.com/latest/defines.html#defines.prototypes), so `defines.prototypes.item`.

Add package alias for core/base/mods in general

I just looked into it and it looks pretty darn complicated. So maybe just keep the absolute paths ¯\_(ツ)_/¯

Fix unescaped interpolated reserved key in help text and handle escaped interpolations in inconsistent interpolations check

@edolix As per the PR description, the tests are failing because they need they need the PR in the i18n gem to be merged: https://github.com/ruby-i18n/i18n/pull/688. Without that PR, escaping the...

Fix unescaped interpolated reserved key in help text and handle escaped interpolations in inconsistent interpolations check

The i18n gem [v1.14.5](https://github.com/ruby-i18n/i18n/releases/tag/v1.14.5) has been released with the needed fix to respect escaped interpolations. So this PR is now good to go.

Fix unescaped interpolated reserved key in help text and handle escaped interpolations in inconsistent interpolations check

Done. Apologies for the force pushes, a testing commit ended up on the wrong branch.

[BUG] Unexpected and inconsistent handling of escaped interpolation arguments

I started looking into the MissingInterpolationArgument error and found https://github.com/ruby-i18n/i18n/blob/master/lib/i18n/tests/interpolation.rb#L6-L18, apologies for not seeing this sooner. According to that code comment, i18n should not alter the string if no substitutions...

Replace deprecated fail-on-error reviewdog flag with fail-level

Done :+1:

Replace deprecated fail-on-error reviewdog flag with fail-level

I've updated the files to include both suggestions :+1: