Bharat Sinha comments

Results 19 comments of


                                            Bharat Sinha

it does not autoplay and pagination dot does not work when scrolling pages in ios

Yes, facing the same issue on iOS

Improve Cache-Control header parsing and handling

I can work on this. I do have a question on the response header, though. If either or both `no-cache` and `no-store` are used, how should the `max-age` and `Etag`...

Not cached with postman

To add to @Sajadrahimi's comment. Another way you can disable `Cache-Control: no-cache` set by postman is by simply sending a dummy header eg: ``` Cache-Control: ``` I recommend labeling it...

Library should handle unexpected exception related to backend

I am happy to create a PR to gracefully handle this.

Library should handle unexpected exception related to backend

> Welcome PR. > > Returning 503 directly when unable to connect to redis would be a good approach. I was thinking "disable rate limiting if backend is down". The...

Library should handle unexpected exception related to backend

PR for the requested enhancements https://github.com/abersheeran/asgi-ratelimit/pull/75

Add handling for backend error

@abersheeran Can I get a review for this PR? Thanks

Add handling for backend error

> Please update `README.md`. Updated to the best of my understanding. Please let me know if any additional information needs to be added.

Honor `include` block when loading config from bucket

@ishaan-jaff @krrishdholakia can I get a review on this please. Thanks

Add no-store, no-cache in Cache-Control headers

> Can I do something to help merging the PR ? I need it in one of my project. @zozoh94 the owner @long2ice seems to be inactive. Probably adding more...