Ben Kiarie comments

Results 28 comments of


                                            Ben Kiarie

auto-commit does not auto-install

Hi @pavlovcik, what is the workaround for someone using `~/.bashrc` ?

Run e2e tests over k8s architecture instead of Docker Compose

Hi @dianabarsan have we established confident stability for the K3d e2e to close this or do I move this issue to 4.9.0 ?

Run e2e tests over k8s architecture instead of Docker Compose

Moved to 4.9.0 so as not to hold up the release.

fix(#8803): refactor formatContacts to reduce cognitive complexity

Hi @jkuester , as I wait for the CI to go green please review my refactor when you have a chance. Thanks.

Telemetry - Do not merge

Looks good

CHT deploy script error: upgrade-service image referenced incorrectly

@henokgetachew I can confirm switching to that branch and deploying from there worked.

feat(#6543): only show assigned facilities without children for users with multiple facilities

Hi @dianabarsan one change I did in the webapp is to add a method to typecast string facility_id to array ``` private getUserFacilityId(userSettings) { return Array.isArray(userSettings.facility_id) ? userSettings.facility_id : [userSettings.facility_id];...

perf(#9006): reduce contacts page_size and refactor ngOnInit

HI @jkuester, 👋 I had attempted some magic 🪄 ....but I could not see any perf improvements, that's why I withdrew the review request as I do more digging ⛏️...

feat(#6543): adds api-side support for users with multiple facilities

Hi @dianabarsan Jenni's [comment](https://github.com/medic/cht-core/pull/9126#issuecomment-2124127168) suggests we should not change the `URL` for [create-user to v3](https://github.com/medic/cht-core/blob/fc98a76f9128b4737a366f210a1330229529474a/admin/src/js/services/create-user.js#L4) and instead use [createMultipleUsers](https://github.com/medic/cht-core/blob/fc98a76f9128b4737a366f210a1330229529474a/admin/src/js/services/create-user.js#L45C13-L45C32) . However, that's not correct since the createMultipleUsers is for bulk...

feat(#6543): adds api-side support for users with multiple facilities

That's okay. But as it is... When I create a new user it goes to the v2 URL and fails