Arthur Joppart

> Just FYI should you request a review soon: next week I'm on holidays. I am also not working next week and the week of august the first. So there...

@ixuz , I fixed two issues mentioned above: > [comment](https://github.com/CommunitySolidServer/CommunitySolidServer/pull/1388#issuecomment-1220704948): @BelgianNoise I was doing some further testing with this PR and I noticed that the type property is incorrectly set...

> One more thing can we also include the `topic` in the notification object? It was included in our initial implementation, but looks like it's missing in this version. I...

> Correct me if I'm wrong, but I believe it could be possible by doing the following: > > 1. Add a `"topic"` property to interface ["WebHookSubscription2021"](https://github.com/CommunitySolidServer/CommunitySolidServer/blob/feat/notification-webhooks/src/notification/webhook-subscription-2021/WebHookSubscription2021Handler.ts#L14-L17). > 2. Populate...

@ixuz, I pushed a commit that includes the proposed changes, I do not think it has the result that you desire. Would you mind giving the commit a quick test...

@ixuz @TamSzaGot I made a similar implementation to your suggestion. What it does: A notification will be sent to subscriptions of the ***direct*** parent, but only when a resource is...

@ixuz I added an in memory config file (`notification-memory.json`). I used the already existing `urn:solid-server:default:ResourceLocker` variable as locker instead of a new custom one. This should not have any drawbacks.

Is this the sign for us to choose another package ?

I had a similar issue, my steps: - Have generator blocks in inventory - Recharge "Wireless Crafting Grid" - Craft more of the same generator blocks (old ones will have...