Adam Beili

Results 66 comments of Adam Beili

hi, will this be implemented any time soon?

> Not on my roadmap, but PRs welcome! It should be possible by simply replacing the [`threeRender.render(scene, scene.camera)` line in the `Renderer`](https://github.com/google/model-viewer/blob/61435b8b2aaf160b92317b8d27e00cf8e86eefb3/packages/model-viewer/src/three-components/Renderer.ts#L494) with `composer.render()` from this [example](https://threejs.org/docs/#manual/en/introduction/How-to-use-post-processing), right? Or is...

1. For the native WebXRRenderer for three.js, it requires some tinkering with the renderers that isn't fully supported yet by pmndrs/postprocesssing, which maybe shouldn't enter model-viewer as it is meant...

After several hours of testing different options and playing with chrome://flags and comparing chrome://gpu settings I have found the issue: The sRGB transfer function of the display. The default display...

![image](https://user-images.githubusercontent.com/54665621/231318901-c0e84228-f4d1-41ad-b741-f6748534a5de.png) I have reproduced it on windows as well by setting the Color Profile to anything but the default **sRGB IEC61966-2.1**, so this isn't a platform specific issue at all,...

@vanruesc Just tested it, makes no difference.

Amazing! I added this to my startup scripts, the fact that it's a hook actually makes it really easy to switch it to pointing to the final html static files...

I don't want to revert the change from #12429 as to me that does seem like a logical change (if the `DataSourceDisplay` is `ready` it should stay ready regardless of...

I'll point out that with this fix, requestRenderMode reverts to the previous behavior where renders are only requested after **all** datasources under the DataSourceDisplay finish asynchronous work. This can actually...

Glad I could help @jasonmprop, The second commit is a more technically correct fix, from what I can see more or less the `requestRender()` that we call manually whenever updating...