Beihao Zhou
Beihao Zhou
Hi @Yangsx-1! I have a question about `MakeCmdAttr`. What are `first_key`, `last_key`, and `key_step` for here? Also for the `description` field, should I have `no-dbsize-check` for `XCLAIM`? Thanks a lot!!
> Hi @Beihao-Zhou. First_key, last_key, and key_step are Redis key range. For this command, it will be 1 1 1. In my opinion, this command could not add the `no-dbsize-check`...
> @Beihao-Zhou Thanks for your patch. Can you fix the CI first? https://github.com/apache/kvrocks/actions/runs/8500498583/job/23284955556?pr=2202#step:7:1062 Sry for the late reply. Sure thing, it's fixed now! I've ran both `./x.py check tidy` and...
> @Beihao-Zhou You can enable action in your [fork repo](https://github.com/Beihao-Zhou/kvrocks/actions),it is free! Thanks for telling me that!!
> You can fix the CI first. Sure thing, will fix it and modify code this weekend!
@Yangsx-1 Hiii! Code and CI are fixed (CI succeeds on my fork). Could you please take a look at the PR again? Thanks!!
Also wondering does anyone know why the linting check couldn't pass as shown with errors (https://github.com/Beihao-Zhou/kvrocks/actions/runs/9052637137/job/24870567712#step:7:1493).
@Yangsx-1 Thanks for reviewing! Everything is fixed then :))
Hi @Yangsx-1 ! I want to work on the issue, can you please assign it to me? Thank you!
Thanks! Would it be possible to add details about the encoding and outline the next steps in this PR, similar to how it was done in [this PR](https://github.com/apache/kvrocks/pull/2368)? I think...