Alex Beaman
Alex Beaman
Let me know if you think this little cleanup is useful. I noticed this text was used in multiple places and thought it could be nice to make a component...
### Details ### Fixed Issues $ https://github.com/Expensify/App/issues/11063 ### Tests 1. Download sample `jpg`, `jpeg`, `gif`, and `bmp` files from this site: https://filesamples.com/formats/bmp (or use your own if you have any)...
### Details Approver shouldn't be able to "Approve" an expense report IFF the report's policy is a Collect Policy, on "Instant Submit" reporting frequency, with "Submit & Close" approval mode....
If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding and email [email protected] to request to join our Slack channel! ___ **Version Number:** Current **Reproducible in staging?:** Y **Reproducible...
If you haven’t already, check out our [contributing guidelines](https://github.com/Expensify/ReactNativeChat/blob/main/contributingGuides/CONTRIBUTING.md) for onboarding and email [email protected] to request to join our Slack channel! ___ **Expensify/Expensify Issue URL:** https://github.com/Expensify/Expensify/issues/430318 **Slack conversation** (hyperlinked to...
## Background: > _**strongly encouraged** suggestion_: Write some automated tests to cover this change. It's a very good candidate for unit tests, and they'd go a long way to make...