Bas van Zanten

Results 28 comments of Bas van Zanten

Something we should look into: ![image](https://user-images.githubusercontent.com/34792838/130292720-42e332b3-4b45-4821-9103-d66ceb72dcd8.png) If non-korean letters are included in the text those letters take twice as long to display.

> Thank you for contributing to this library. > I didn't expect to receive other people's PR from foreign countries. > This is a very interesting and exciting experience. Hahaha...

> If non-korean letters are included in the text those letters take twice as long to display. Fixed in https://github.com/Bas950/type-hangul/commit/e99dd60d3833f070f9902ba7fc04ddaa3a4bcb50 ![image](https://user-images.githubusercontent.com/34792838/130316001-993b9be2-3749-4b4d-a89c-8f29b60db49a.png) There is still an extra timeout after it finished...

Something I haven't checked yet; But maybe the main in `package.json` needs to be changed to the `index.js` file.

> Can reproduce, with presence from the store but not locally only with the store version. > > ![image](https://user-images.githubusercontent.com/42322979/182317905-3e24843f-f31e-4356-bf72-cf6d93ccf966.png) > > Seems to be this (line 118): > ```function asyncGeneratorStep(e,...

> > Feel free to pr it yourself > > For both or only this issue? both

@DarkVillager are you making a PR?

Undo the packagejson and yarnlock too

@DarkVillager @RisingSunLight42 could one of you maybe look at this one, it might be as simple as changing the url in metadata. Not sure tho xD