René Vollmer

Hi, this looks very interesting and I guess I'll take a closer look at it soon. I just noticed, that the website seems to not be reachable anymore. Cheers!

This example has the private key in the "public" js file. I don't think this is good for production (and so do others: https://groups.google.com/forum/#!searchin/freesound-api/javascript/freesound-api/7DdxIx5FggU/6D0xnvxKK2kJ ). There should be a mention...

API documentation and other access points

4

Thanks for this wrapper! I could not find any reference to the API used and if it is applicable to any other access point than the M4. Do you have...

Example: External IP

3

See https://stackoverflow.com/questions/41695810/sending-tr064-requests-to-avm-fritzbox-7270

Allow for https

3

As seen in #7 it might be neccessairy to use http**s** for some queries. Make that work.

Forward error messages nicely

1

#7 was hard to debug, because the request returned an empty reply rather than an error message. Consider returning an error message instead.

In #5 we saw, that in some cases, there are additional commands to be found under: > AVM implemented the new protocoll after 6.50 fritz os > http://fritz.box:49000/igddesc.xml > http://fritz.box:49000/igdconnSCPD.xml...

Not working when passwort auth is disabled

3

When a FritzBox is configured to not require authentication, the reply never contains a nonce. This makes this script fail, even though no authentication is required and it could just...

Make it easier for users to understand the TR-064 API / commands

2

It is currently rather hard to get an idea which commands are available over the API. Make this easier. Either consider a dedicated tool or a function within the library....

Allow user to pass stream object rather than hard-coded "Serial"

2

From https://www.arduino.cc/en/Reference/APIStyleGuide: > When using serial communication, allow the user to specify any Stream object, rather than hard-coding "Serial". This will make your library compatible all serial ports on Mega...