Piotr Gawryś
Piotr Gawryś
> There is still a lot of work to be done including writing tests. If you'd like to split some of it, I would be happy to lend a hand!
Awesome! Should I add things to your PR or wait after it's merged? I will have a limited access to the internet for a couple of days (Saturday - Wednesday)...
I will create a prototype
@snowleopard I finally found some time to start working on this and I'm wondering about operations that combine graphs, e.g. `overlay`. If we define `value :: Int -> a` and...
> Do you have an idea of how we could do this both efficiently and in a compositional way to permit operations like overlay? No clue but I will try...
@snowleopard I will try validating @michaelpj ideas first, maybe it can lead us somewhere. :D > * Redo the indices for one side: > > * For each mapping therein:...
@snowleopard I managed to implement and benchmark few functions. I plan to add tests now so I can get rid of bugs and then keep trying to optimize. Though any...
I added implementations for `removeVertex`, `removeEdge` and improved `hasVertex`: ``` hasVertex: 1.04 (OK) removeEdge: 0.80 (good) removeVertex: 0.55 (good) ``` I don't really understand why removing is so fast and...
I think the issue with `vertexCount` was caused by a bug I've had in `overlay`, latest results are: ``` addEdge: 27.98 (bad) addVertex: 20.13 (bad) creation: 3.36 (bad) edgeCount: 3.31...
@snowleopard Current implementation of `overlay` and `connect` is quite involved so I assume it is possible to simplify it https://github.com/Avasil/alga/blob/adjMap-alternative-impl/src/Algebra/Graph/AdjacencyMapPoc.hs#L282 I haven't looked into it yet