Evelyn Osman
Evelyn Osman
I did some further testing, here's the goodies: The IAM user must have the following permissions to use SSE-KMS: ```json { "Sid": "KMSAllow", "Effect": "Allow", "Action": [ "kms:Encrypt", "kms:Decrypt", "kms:ReEncrypt*",...
@maishsk I can probably launch a bunch with terraform then try this, hopefully get to it within the next week but I can't make any promises.
What do you think about including test for exceptions? The unfortunate part is that the code uses the catch-all exception so we don't have a very precise way to test...
The aim would be to increase test coverage, I think checking that it was written to the log may not increase coverage of the code in question since we want...
Okay understood, I think that would be a worthwhile test!
This looks **much** better than my attachments implementation.
Apologies for the silence these past few months, I'll be trying to take some time in the coming week to review and leave my own feedback.
I believe so. I've finally started revisiting this project and started to look at this PR yesterday. Regarding colors, the only color I'd say is missing would be red. It...
I like the simplicity of letting the dev set an arbitrary color as an override to the default. I believe if we provide a sane default set we can consider...
Now that Travis is fixed can you rebase on master to trigger a run?