Asha20
Asha20
@sharkdp Should I keep working on this PR?
It's okay, you did mention you were pretty busy in the Reddit post asking for contributors. I fixed the merge conflicts, refactored the code a tiny bit and then ran...
It's a lot better now! Here are the new benchmark results: Benchmark report file ## `fd` regression benchmark ### No pattern | Command | Mean [ms] | Min [ms] |...
I like the previous implementation more too honestly, though it does seem to have a noticeable impact; you can be the judge of whether it's acceptable or not. Here's a...
Should the code stay as it is then? The metadata filters are next up for similar refactoring as per the first comment of the issue.
How would you handle optional filters with that approach? ```rust let filters = { let filters = SkipRoot .chain(MinDepth::new(config.min_depth)) .chain(RegexMatch::new(pattern, config.search_full_path)) .chain(Extensions::new(config.extensions.as_ref())); if let Some(file_types) = config.file_types.clone() { filters.chain(file_types) }...
I think we can tidy up [`spawn_senders`](https://github.com/sharkdp/fd/blob/049232439ab1bc19b08739eb29852ab967eb7d6c/src/walk.rs#L331-L495) quite a bit, but since it's a large chunk of code I figured I'd post my thoughts here first, start a discussion and...
I can never remember the `if let` syntax haha; it just feels so backwards! In any case, can I start working on a PR or should we wait for more...
I see that besides `RXingResultPoint` there's also a `Point` struct and a `ResultPoint` trait. What do you think about removing the latter two and renaming `RXingResultPoint` into just `Point` or...
I've edited the original comment to include a list of goals for this issue. Let me know if you have any suggestions or comments.