AshGDS
AshGDS
We've discovered that `finder-frontend` doesn't use `jasmine-jquery` for its tests, which prompted us to investigate what `jasmine-jquery` is doing for us. It looks like it adds extra matchers (e.g. `.toBeVisible()`,...
Thanks @andysellick - should be ready for re-review 👍
Thanks both 👍 @maxgds will do. Last time we did the Whitehall change ourselves, should we do it ourselves again just to reduce dependency on other teams? https://github.com/alphagov/whitehall/pull/9379
Thanks @kevindew - yep it isn't the best solution. For some more context, I believe initially I had left my PR as a draft for some time, as I was...
Thanks @kevindew - yep the `` approach seemed great except for that anchor issue 😅. Good idea moving it into the public layout, that approach seems like it will work....
Should be fixed now as a result of https://github.com/alphagov/govuk_publishing_components/pull/4855
@andysellick I've approved the visual changes as well 👍
For context, this was introduced when the header had a different design, so it's likely that updating this border was missed when the header design changed. The PR that added...
From frontenders catchup: check if No 10 is setup to still be able to use this image card so we don't break anything if they decide to use it -...
@andysellick I've got it working without any Linting/CI/CSP errors anymore - `bundle exec rake` should pass locally now. The PR will still fail as the data is missing in GitHub....