Arnoways comments

Results 8 comments of


                                            Arnoways

Add service discovery for OvhCloud

Hi @roidelapluie I updated the PR trying to remove the extra libraries and tidying the tests. Let me know what you think

Capture usename and application_name for pg_stat_activity

Hi, thank you for this work. I've been able to test it myself on a few instances and it lgtm. This will really help to have this out of the...

Add service discovery for OvhCloud

Hello @roidelapluie , any chance you could take a new look at the modifications please?

Capture usename and application_name for pg_stat_activity

Hi, small bump as I'm hoping to see this reviewed soon. Thanks for your time.

haproxy_exporter: escape cnf_scrape_uri to avoid malformed strings

> > Hi, thanks for providing this PR. Could you add a unit test to verify this works as expected? Hello, I never done any tests in ruby so I...

haproxy_exporter: escape cnf_scrape_uri to avoid malformed strings

> > Hi, thanks for providing this PR. Could you add a unit test to verify this works as expected? Hello, I never done any tests in ruby so I...

haproxy_exporter: escape cnf_scrape_uri to avoid malformed strings

> @Arnoways do you have any idea why the tests fail on Ubuntu 16? I have no idea. I don't see any relation between the errors and my modification. Do...

Fixes for concurrency control

Hi, Any chance this bug fix might get some love ? It would be awesome to get this setting to work.