Archit Bhonsle
Archit Bhonsle
So what's the status for this? Noticed that I still had the default mappings even though I set `mappings = nil`
If this issue has been abandoned, I could start working on this. > The mp4 code has a different flow. We use libgpac to actually open the mp4 file and...
Any idea why this PR isn't merged? Is there some work left?
I was on the first task. Any idea how the [`encoder`](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/ccx_decoders_708.h#L359) should be instantiated? The [current rust code](https://github.com/CCExtractor/ccextractor/blob/master/src/rust/src/decoder/mod.rs#L44) just copies it over from the context it is passed while the...
If could push my progress but because of how I'm working, the commits themselves would fail to build. Is that okay?
Also how do I approach the compatibility issue. The `encoder` for example. It would be initialized to `NULL` but in Rust should I use the Rusty approach of using `Option`...
And other issue is stuff like [`dtvcc_tv_screen`](https://github.com/CCExtractor/ccextractor/blob/master/src/lib_ccx/ccx_dtvcc.c#L111) where in C we just allocate memory for it and assign some of the values while the rest are left as garbage. While...
@PunitLodha here's the PR #1501. For now I've just rewritten `Dtvcc::new()`.
> It should start with NULL - please send a PR to correct that in the C code :-) Just a matter of hygiene. If you look at the actual...
@PunitLodha for the mp4 part, do I just expose another extern function from Rust to call [this](https://github.com/ArchitBhonsle/ccextractor/blob/c9d9e2357d1223872e0aca7d47c73f61e13b86f6/src/rust/src/decoder/mod.rs#L127) or somehow reuse [this](https://github.com/ArchitBhonsle/ccextractor/blob/c9d9e2357d1223872e0aca7d47c73f61e13b86f6/src/rust/src/lib.rs#L85)?