Aradhya Tripathi
Aradhya Tripathi
Unnecessary PseudoColumn requirements everywhere...Don't know why get all supports it. Example -> ```python frappe.get_all("DocShare", fields=["`name`", "`user`", "write"]) ``` Gives the same output as ```python frappe.get_all("DocShare", fields=["name", "user", "write"]) ``` ```sql...
> @Aradhya-Tripathi changes are looking good. I noticed that we do not have any documentation for `frappe.qb.engine`... please also add that with this PR. I'll raise another PR for the...
For Postgres both datepart and timepart would need to be strings for concatenation.
Failing tests don't seem to be related to the changes made in this PR.
Checking for PseudoColumns everywhere need to find a better way to address PseudoColumns
> can we also extend the test `test_implicit_join_query` for multiple child table fields (?) > > would be helpful in testing the problem of multiple joins (which used to happen...
> This broadly works fine (i think). > > some problems: > > >  > > `as` with and without backticks gives 2 different queries -...
Hey @gitaalekhyapaul , isn't the regex validation enough for now?
> Cool as long as we're not using this for user-input validation, that might be an overkill 👍🏿
Please use the checklist if you're leaving the template for the same in your description!