Daniil Ankushin
Daniil Ankushin
@obasekiosa 64 = 0b1000000 If truncate to length = 2, we have 0b00 or 0b0, and if we count significant figures, the length should be 0 or 1.
@bradleycamacho Could you please review this PR? 🙏
Tested by running `./build/juno --http --vm-concurrency-mode` and requesting ```json { "jsonrpc":"2.0", "method":"starknet_traceTransaction", "params":["0x5634f2847140263ba59480ad4781dacc9991d0365145489b27a198ebed2f969"], "id":1 } ``` Response body ```json { "jsonrpc": "2.0", "result": { "type": "INVOKE", "execute_invocation": { "contract_address": "0x31c9cdb9b00cb35cf31c05855c0ec3ecf6f7952a1ce6e3c53c3455fcd75a280",...
The current problem is [this](https://github.com/NethermindEth/juno/actions/runs/10450945256/job/28936774568) bug. It happened in sequential mode. My hypotheses were: 1. Transaction preparation loop: In the updated code, transactions are first prepared and stored in a...
To make it work in my branch: 1. in `vm/rust` run `make clean` 1. [here](https://github.com/starkware-libs/sequencer/blob/cee1f5b985302cf3e5f0474491e6d53c76934840/crates/blockifier/src/blockifier/transaction_executor.rs#L95) and [here](https://github.com/starkware-libs/sequencer/blob/cee1f5b985302cf3e5f0474491e6d53c76934840/crates/blockifier/src/concurrency/worker_logic.rs#L133) `validate: false` 1. in `vm/rust` run `make all` 1. make juno 1. `./build/juno...
[Pathfinder](https://github.com/eqlabs/pathfinder) team encountered [the same problem](https://github.com/eqlabs/pathfinder/issues/2125#issuecomment-2273434728)
I tried to measure performance by running multiple transactions and found a new bug. The error is `Transaction with no fee transfer info must have zero fee.` This happens [here](https://github.com/AnkushinDaniil/sequencer/blob/c529904b1c57963e1183aa66f2bca5c2bfc67cd9/crates/blockifier/src/concurrency/fee_utils.rs#L62-L63)...
> Also curious what the performance of simulating a block in concurrency mode is as well. I roughly measured the performance difference. I used a slice of different txs from...
@obasekiosa Hey there! I was wondering if you wouldn't mind if I took on this task?
If earlier we processed all transactions sequentially, at the moment we must first collect `txs` from `txns_and_query_bits`, start `tx_executor`, wait until it finishes and in `for (txn_index, result) in res.iter().enumerate()`...