Ankan

Results 113 comments of Ankan

@MrishoLukamba Can you also add a test that documents what happens in the scenario where MaxUnlockingChunks is reduced without migration? Here are couple of examples you can refer https://github.com/paritytech/substrate/blob/ankan/bound-staking-storage-trivial/frame/staking/src/tests.rs#L4872 https://github.com/paritytech/substrate/blob/ankan/bound-staking-storage-trivial/frame/staking/src/tests.rs#L5367

> @Ank4n @kianenigma There is an issue which I noticed, StakingLedger.staking BoundedVec does not push new object (UnlockingChunks) instead it just increments the value inside UnlockingChunks. So the MaxUnlockingChunks bound...

> > > @Ank4n @kianenigma There is an issue which I noticed, StakingLedger.staking BoundedVec does not push new object (UnlockingChunks) instead it just increments the value inside UnlockingChunks. So the...

@MrishoLukamba I will close this PR and work on top of your code to get it merged. Pls add your Polkadot address in the PR for the tip. Super thanks...

Minor nitpicks but LGTM! :+1:

> is anyone still on this issue? @MrishoLukamba Feel free to pick it up :+1:

> @Ank4n @MrishoLukamba Are you working on this? If not I may pick this up. @Szegoo No one is working on this currently.

/cmd queue -c fmt $ 1

> just a minor note: https://github.com/paritytech/substrate/blob/master/docs/CONTRIBUTING.adoc#rules Noted