Angus

Results 10 comments of Angus

My understanding is that this is a limitation/issue in the [htmljs](https://github.com/marko-js/htmljs-parser) parser. There is no native representation of import/export in the parser, they are parsed as concise mode tags. One...

We're seeing this too, could this be because `readBrowserProperties()` triggers a forced synchronous layout? So, the `ResizeObserver` calls `readBrowserProperties()` which forces a synchronous layout that then enqueues a new resize...

This issue seems related to the auto import, or the way the typescript gets generated for the auto imports. Doing a manual import of the tag works as-expected: ```marko import...

I've got a reproduction [here](https://github.com/AngusMorton/marko-lsp-bug/tree/am/custom-tag-import-error) that is just the `basic-ts` example with most of the code removed. Interestingly, doing `import titleComponent from ""` also causes the bug while doing the...

Sounds good! :) I've published it as [an extension](https://marketplace.visualstudio.com/items?itemName=AngusMorton.polar-vscode) and will aim to keep it in sync with this repo. Let me know if I can contribute if/when you decide...

Closing for now, will re-open a clean PR.

Yeah, I'm thinking about special casing the global rules. I'll give it a go tonight and see how far I get!

My understanding is that this is a limitation/issue in the [htmljs](https://github.com/marko-js/htmljs-parser) parser. There is no native representation of import/export in the parser, they are parsed as concise mode tags. One...

> We should probably make getBrowserProperties only do the expensive stuff conditionally as well; 1/3 callers don't even use the expensive viewport/documentSize values and it's when the tracker first loads...