Angus Johnson

Results 83 comments of Angus Johnson

Thanks Juha. I can confirm that this is an issue. Howver I'm currently occupied with other things so I doubt I'll get a chance to look at this for a...

Hi Jasper. Thank you for the PR, and from the little I've seen so far, it seems very nicely done (and well commented too). However, it'll probably take me a...

Thanks Jasper. I'm still here, but I'm currently caught up with other things.

Jasper, while I'm very slowly assimilating your proposed changes, and taking in to consideration your suggestions, I've tweaked the documentation in `clipper.export.h` further. And no doubt it'll need further tweaking....

> I will update the PR with your text documentation changes in clipper.export.h. > EDIT: Done, see new commit And I've just edited my post above 😱 with further tweaks...

`TestExportHeaders.cpp` also needs updating ... https://github.com/AngusJohnson/Clipper2/blob/c19da7257e7d3efdd02aede46d011fcf2f1bf4cc/CPP/Tests/TestExportHeaders.cpp#L12-L16 ``` for (size_t i = 0; i < poly_len; ++i) { int64_t x = *v++, y = *v++; #ifdef USINGZ auto z = bit_cast(*v++);...

Hi again Jasper. Yes, I am slowly progressing 😁, and I've attached a zip file containing quite a few changes. I will probably make a branch here soonish and upload...

> As a matter of opinion, I would have not included the double overloads, since internally you still operate only on the integral values. I would have expected this as...

> I was wrong. There is a way to make it polymorphic! Your double structures use a double type to store integer values. So, it's easy to detect if the...

> Let me know if you need any more changes on this item No. Please hold off for now. I'm hoping to upload my own changes in the next few...