AndyNewlands

Results 6 comments of AndyNewlands

Hi. I'm not sure why these unit tests are failing: `uac_digest_leak_udp` and `uac_digest_leak_tcp` To my knowledge I have not changed anything which should affect these (just do_flush(), in switch_rtp.c -...

Thanks for confirming @yois615 . I dunno how to fix. I posted a question about this to the FS DEV mailing list.. Not sure if I'll get a reply -...

@dragos-oancea @andywolk As mentioned, my changes seem unrelated to the unit test failures I was getting. Any thoughts on how I can fix that. Also, in respect of your suggestion...

@dragos-oancea @andywolk I've added the check for SWITCH_RTP_FLAG_SRTP_HANGUP_ON_ERROR and ripped out the code which was using SWITCH_RTP_FLAG_NACK. Unit tests now all passed (nothing to do with my changes as far...

Hi @dragos-oancea @andywolk - did you see my comment (above), from a couple of weeks ago?

Hi @dragos-oancea @andywolk - should I withdraw this PR? Thanks.