Andre Kurait

Results 36 comments of Andre Kurait

The current implementation requires the www subdomain for websites without a subdomain. Try www.my-domain.com

Hi, I'm seeing this with 2.23.1 and Disruptor 4.0.0 in my application. It's happening when i use: ``` Log4jContextSelector=org.apache.logging.log4j.core.async.AsyncLoggerContextSelector AsyncLogger.WaitStrategy=Yield ``` ``` "Log4j2-TF-1-AsyncLogger[AsyncContext@3b192d32]-1" - Thread t@14 java.lang.Thread.State: RUNNABLE at [email protected]/java.lang.Thread.yield(Native...

I've created a PR fixing these errors by moving the log syntax to `.addArgument`. Seeking feedback from others on other solutions https://github.com/opensearch-project/opensearch-migrations/pull/632

Here's a page on Log4j's page discussing how string concatenation like we currently use it may be vulnerable to attacks https://github.com/apache/logging-log4j2/blob/2.x/src/site/antora/modules/ROOT/pages/5min.adoc#dont-use-string-concatenation

Furthermore, consider >I'd like to see us pull back the disruptor changes altogether & even just switching to WARN for everything other than progressLogging, tupleLogging, and longRunningActivity logging. https://github.com/opensearch-project/opensearch-migrations/pull/634#pullrequestreview-2039462723

I've encountered this ``` [WARN ] 2024-04-01 20:29:40,756 [targetConnectionPool-3-1] RequestSenderOrchestrator - Scheduled future did not successfully run IndexedChannelInteraction(channelKey=d9f9d3ac-a02c-46aa-b842-f67320505052.027e57fffee80927-0000000a-00001185-649b0a3562694922-98a320e2.1143\|partition=0\|offset=295150, index=7423) -- java.lang.IllegalStateException: stream has already been operated upon or closed at...

Please update the PR overview before merging

@kanatti - Thanks for the feedback! Yes, that is understood, i've specified that behavior as "First execute all deletes, then all adds/updates" in the original plan. Does that alleviate any...

@IanHoang, which parameter do you mean by branch, do you mean `bulk_indexing_clients:1`? Is there a different way to specify these 4 workloads?

We plan to build the images using github actions. Original communication with @Divyaasm resulted in a recommendation to have our github action publish to dockerhub staging then jenkins copy to...