Anders Bennedsgaard
Anders Bennedsgaard
I agree, the documentation could be improved with regards to the garbage collection. The reason for this discrepancy with roles not being removed, is that https://github.com/banzaicloud/bank-vaults/pull/1513 only introduced garbage collection...
@stefanprodan that's good, I will get back to it in the next week. I agree that allowing the use of `latest`, would be a nice addition. However, I don't think...
@stefanprodan I have tried to give a take on how to use the latest version, changed `helmv3` references to `helm`, and removed any Docker-related files (`Dockerfile`, `src/`, and `Makefile`). I...
@stefanprodan I have removed Go, fixed the permissions error when installing `kubectl`, and added some caching which is not fully tested.
@stefanprodan I have removed `kustomize`. I did not realize how many tools come preinstalled with the GH runners, which is why my tests with [nektos/act](https://github.com/nektos/act) didn't catch the errors we...
@stefanprodan I've removed each tool in its respective install step, but I don't know if I agree that it's the responsibility of the action. In my opinion, the test workflow...
> If the test workflow tested the input version and that the correct version was installed, that would certainly better test the action as a whole, I think. > >...
@stefanprodan https://github.com/kubernetes-sigs/kustomize/issues/1009#issuecomment-801460003 shows how you would be able to work around the problem, but more importantly I think, is that in later versions of Kustomize, https://github.com/kubernetes-sigs/kustomize/pull/3743 has been merged into...
I agree, creating a `commonLabels` field with a different behavior from the one with Kustomize would get confusing for people who are actually aware of the behavior of Kustomize, but,...
Just to expand on my reason for adding the fields to the `Kustomization`: I help run a multi-tenant setup, where some of the tenants does not care much for Kubernetes....