Anddd7
Anddd7
avg(working_time_of_projects) 这种事我司的一贯作风不是应该feedback cc china嘛
The Cluster and Node are different source in graphviz. So it cannot put a VPC(Node) as a Cluster. I think there are bunch of PRs making it possible (https://github.com/mingrammer/diagrams/pull/823). But...
I create a fork to use it as a local dependency, you can check https://github.com/Anddd7/diagrams-ext/pull/1. Make a copy by your self or use my main branch.
sure, i don't want to add annotations directly in this repo, that will bring chaos (like you said). 😄 i just want a mechanism that support custom annotations at runtime,...
@Anddd7 TODO add docs for annoations and configmap
@longwuyuan to avoid bringing big changes, i set the grpc timeouts with existing proxy timeouts when backend protocol is 'grpc/grpcs'. so we can simply reuse `proxy-send-timeout` - just set `backend-protocol=grpc`....
@longwuyuan @rikatz thanks, good suggestions. i implemented it with new annotations at beginning, like `grpc-send-timeout`. but i found it doesn't make sense to set any grpc timeouts without setting `backend-protocol:...
I had some tests for the nginx and grpc timeouts: grpc connection will only be affected by grpc timeouts. if you set backend protocol as GRPC, no matter you set...
aha, i haven't changed my design (how to implement this feature), just clarify the `proxy_send_timeout` cannot work with `grpc_send_timeout` on grpc connection at this moment. > wrong: ~~but proxy-send-timeout is...
> I think the current approach of achieving this through composition of annotations (without introducing new annotations) is great. > > Could you please add an e2e test case to...