Amit Joki
Amit Joki
I think the following is a general solution and that which is more elegant. ``` var urlify = function(str, length) { var strArr = []; for(var i = 0; i...
It is a simpler implementation and which is more easier to read in my opinion.
The one in the original code counts a single character as 1. ``` console.log('aabcccccaaa', compress('aabcccccaaa'), 'a2b1c5a3'); ``` As you can see `b1` is present in the original code. As far...
Huh. I guess I didn't test it on production. Will sort it out and push a commit.
The error of webpack-isomorphic-tools/plugin is frustrating to solve. This pull request works and there's no errors in the console when I tried after a `yarn build` and `yarn start` so...
@ragesoss can I include this in GCI? The script is already there, it needs to be tested and improved, if there's the scope for it and document the whole thing,...
@ragesoss @bwreid per @urbanecm 's comments, the generic word "improve" needs to be elaborated more so we can quantify the work done. Do you have any particular improvement in mind...
@ragesoss I will reword this task to just test the existing script and if we have a more objective idea of how to improve the same, I'll add another task...
@urbanecm done :)
The tests and documentation can be submitted as a pull request to this repository. @urbanecm