Lily Brown
Lily Brown
@dtolnay I think this is ready for review now.
I'm not sure if deep-freezing tables is even possible in Lua without `__pairs` and `__ipairs`. Deep-freezing in Lua 5.1 *must* either: * Allow mutations of existing keys (bad) * Not...
It's easy to implement `setComponentName`, but that raises the question: where is this name *read*? Is it intended to be used in debugging with `print` statements or the Lua debugger?...
Maybe we could conditionally enable it in `GlobalConfig`?
Since NoYield is now much better about reporting coroutine stack traces, I think this could use some more thought - yielding in lifecycle hooks is still a Very Bad Thing:tm:!...
Should this be enabled with `DEBUG_ENABLE()` or should it be a separate function?
I've got a branch for logging actual mutations to Roblox objects; a question has come up: should this also log instance creation/destruction?
This seems like something we should document. I'm pretty sure most (all?) uses of Roact in the wild don't re-use property tables, so.. If we feel the need to not...
One thought I had on this: if someone wants to re-use the props table across multiple different components, they'll get weird behavior: ```lua local SHARED_PROPS = { -- ... }...
We can also document some performance tips that Roact can't do on its own. One thing that I *think* has an effect but I've not had time to sit down...