Hazel OHearn

Results 33 comments of Hazel OHearn

Great! If I were to do some work atop that, would you prefer I open a PR into your feature, or push it to here? Pushing here for now.

I've marked this as ready for review. It needs tests added, but I'm finding myself at a bit of a loss on how to test this in a meaningful way,...

[Zingo](https://github.com/zingolabs/zingolib) is currently relying on a cargo patch in order to use this builder (it's also patching librustzcash to use https://github.com/zcash/orchard/pull/344). This means all downstream libraries need to copy our...

Re-marked as draft, as this is blocked on zcash/orchard#352

Some of my code is squashed into str4d's initial commit, as doing so made rebasing a lot easier.

> @dannasessha If you have docker you can sanity check the build against our CI image: `docker pull electriccoinco/zcashd-worker-archlinuxv2` > > I do recall some annoying issues on certain versions...

Alright! Librustzcash has moved far enough since I opened this that a rebase proved really difficult, so I reimplemented instead. Ideally, we should get the number of orchard actions from...

There is also a change to `test_only_new_with_rng` so that it returns an existential type `Builder`. This allows `new_internal` to require a CryptoRng bound, which is faked by the test fn....

Testing this locally with zingolib (branch https://github.com/zingolabs/zingolib/pull/185), I'm getting `error_code: -26, error_message: \"16: bad-sapling-bundle-authorization\"`. I haven't touched the sapling authorization code. Have I done something wrong, or is this a...

> @str4d, @daira, @sellout and I had a look at this in PR gardening and determined that the Orchard integration process would be more straightforward if we first changed the...