Allan Nathanson comments

Results 15 comments of


                                            Allan Nathanson

cockpit-networkmanager frontend to `nmcli device wifi list` and `nmcli device wifi connect`

@khimaros can you share the changes that you made?

config.c: fix #tryinclude being converted to #include on rewrite

This change resolves Issue #920

config.c: fix #tryinclude being converted to #include on rewrite

Note : I was asked about the "precomment" changes included in this PR. To set the stage, let's talk about a sample configuration file : ``` 1. ; comment block...

config.c: fix #tryinclude being converted to #include on rewrite

>All your changes should be squashed into a single commit Done.

config.c: fix #tryinclude being converted to #include on rewrite

>The commit message should wrap at 72 characters. Done. > Also, the title could maybe be a bit more descriptive, like "config.c: Fix #tryinclude being converted to #include on rewrite"...

config.c: fix #tryinclude being converted to #include on rewrite

>Looks like you updated the PR description, not the commit itself (which is what matters). I have now updated the commit too :-)

config.c: fix #tryinclude being converted to #include on rewrite

cherry-pick-to: 20 cherry-pick-to: 21 cherry-pick-to: 22

config.c: fix #tryinclude being converted to #include on rewrite

>>And, as a bonus, I also found/fixed the issue where standalone and inline comments in the .conf files were being stripped of all leading whitespace. >Personally, I think this should...

config.c: fix #tryinclude being converted to #include on rewrite

@seanbright, @InterLinked1 : I believe that all requested changes have been made. Can you kindly review?

config.c: fix #tryinclude being converted to #include on rewrite

[PR #1047](https://github.com/asterisk/asterisk/pull/1047) pulled in one of the fixes (a reference leak) that I had found/addressed with my change. I have since rebased and updated this pull request. I believe that...