Sergey V. Alimov
Sergey V. Alimov
It would be worth to merge this upgrade. Thoughts?
Any news?
Also one example with bad escaping: ``` iex> :hackney_multipart.encode_form([{:file, "1\"2.txt"}]) |> elem(0) |> IO.puts -----------------------------cmvkvxjlirmydmjx content-length: 0 content-type: text/plain content-disposition: form-data; name="file"; filename="1"2.txt" -----------------------------cmvkvxjlirmydmjx-- ``` `filename="1"2.txt"` doesn't look correct
Btw, I didn't include updated lock files in this PR because they were totally different. The versions in the repo are using space-based indents but my npm generated tab-based indents....
Looks like the problem is in the `toPathSchema` method, where there is no logic for anyOf/oneOf cases. Try this patch - it works for me: ``` diff --git a/node_modules/@rjsf/core/dist/cjs/utils.js b/node_modules/@rjsf/core/dist/cjs/utils.js...
An additional example of the wrong behavior liveOmit/omitExtraData. When array field identifier contains `.`: - Go to [rjsf playground](https://rjsf-team.github.io/react-jsonschema-form/#eyJmb3JtRGF0YSI6eyJhLmIiOlt7fV19LCJzY2hlbWEiOnsidHlwZSI6Im9iamVjdCIsInByb3BlcnRpZXMiOnsiYS5iIjp7InR5cGUiOiJhcnJheSIsIml0ZW1zIjp7InR5cGUiOiJvYmplY3QiLCJwcm9wZXJ0aWVzIjp7Im5hbWUiOnsidHlwZSI6InN0cmluZyJ9fX0sIm1pbkl0ZW1zIjoxfX19LCJ1aVNjaGVtYSI6e30sInRoZW1lIjoiZGVmYXVsdCIsImxpdmVTZXR0aW5ncyI6eyJ2YWxpZGF0ZSI6ZmFsc2UsImRpc2FibGUiOmZhbHNlLCJyZWFkb25seSI6ZmFsc2UsIm9taXRFeHRyYURhdGEiOnRydWUsImxpdmVPbWl0Ijp0cnVlfX0=). - Notice that Omit extra data and Live omit are set...
Please check this patch, it works for me: ``` diff --git a/node_modules/@rjsf/core/dist/cjs/utils.js b/node_modules/@rjsf/core/dist/cjs/utils.js index 792c921..4075561 100644 --- a/node_modules/@rjsf/core/dist/cjs/utils.js +++ b/node_modules/@rjsf/core/dist/cjs/utils.js @@ -827,6 +827,23 @@ function retrieveSchema(schema) { return resolveCondition(schema, rootSchema,...
@dbaumgarten Yes, I believe this issue was fixed. At least I removed all custom patches after upgrading to 4.2.0 and all works fine.
Hmm, you are right, this schema is not RJSF-compatible. A quick look at the schema tells me that the issue is inside `items: { allOf: [ ... ] }` block....