Olivier Halligon

Results 378 comments of Olivier Halligon

To implement this I see some new `IdentifierGenerator` class to which we can feed a string, it computes the associated identifier, check if it's already used and if so suffix...

Some considerations to take into account when we'll be implementing this: - Do the de-duplication **at the template level** (using a Stencil `Filter`), not directly in the Swift code of...

Totally unrelated, but just realized that the link to the CHANGELOG in the Danger message points to master. Might not be a good idea… I even wonder if it's worth...

As for your two questions: - Haven't really looked at what the generated code looks like yet (in bed from phone here), but not sure that will really be an...

Ok so the problem might be that `ClassB` has two `enum TypedStoryboardSegue` nested types (one coming from parent class, one from child). I might remember a radar in bugs.swift.org about...

I think this is the bug report I was thinking about: https://bugs.swift.org/browse/SR-3492 And I agree, in fact that code we generate should probably not compile, as it should probably not...

Yeah might be the best option for now. How often do you think this kind of situation (both a class and its subclass in the same storyboard and both having...

Well sure we collect all segues over all storyboards but how many of those use the parent class? I'm gonna hypothesise that if you have a parent class with multiple...

Btw not sure if it's adjust the case in the PR but we need a test on a storyboard containing multiple scenes that all use the same UIVC parent class...