Olivier Halligon

Results 378 comments of Olivier Halligon

Some rules not to forget when integrating Danger * [x] Ensure the CHANGELOG has changed when the PR contains code changes * [x] Ensure the CHANGELOG respect the expected format,...

~~Another rule to not to forget to add when we finally take some time to add Danger: Warn if `Podfile.lock` and `Package.resolved` are not changed together (if only one of...

This has been partially implemented in #520 but there are still some future improvements that we'd be interested in after that: * [x] Warn if `Podfile.lock` and `Package.resolved` are not...

Yup, indeed, that's what I thought about using for item 2. (Still doesn't solve item 3 though) Additionally, we _could_ imagine make Danger tell "everything seems good to me!" if...

- [ ] Use `message()` instead of `warn` for "Big PR" message, because Danger using a :warning: sign on this kind of message could make the contributor/PR author think/wonder if...

Ooohh nice! When we talked about that I thought you'd implement it by creating a brand new, separate template. Including that in the original Swift template to allow bridging is...

Btw, you only generated that parameter for the String templates, do you plan to submit other PRs to support ObjC also for other templates (storyboard scenes & segues, colors, images,...

Sure, no pressure. Btw if you need push access to SwiftGen (to avoid doing forks and be able to create branch directly in the repo for an easier contributing experience)...

@djbe I don't want to make the mistake to "one more thing, just take another last-minute PR for 6.0" and merge too fast while we're so close to 6.0, but...

Ok. Right. It doesn't seem ready anyway (in the sense that it passes the CI sure but might miss more docs, decision on merging it alongside the other ObjC PR...