Alfredo Delgado

Results 5 issues of Alfredo Delgado

Just wondering the reasoning behind `initial_guess`to be set flat across all channels. https://github.com/pymc-labs/pymc-marketing/blob/9755d3b16f1389bc695a3dac3495a47e1cce0ee9/pymc_marketing/mmm/budget_optimizer.py#L185 Shouldn't be more helpful and informative to the optimizer to start with a historical share? ```python initial_guess...

good first issue
MMM

Not quite sure if this will be fixed in the upcoming `0.7.0` release but noticed the re-written [BudgetOptimizer](https://github.com/pymc-labs/pymc-marketing/blob/0144bd37d692d43f8575ec2c522289b438f221db/pymc_marketing/mmm/budget_optimizer.py#L33) does not work with time-varying intercept or there's a conflict with `PyTensor`....

bug
MMM

Just following up on the issue discussed below. I encountered the problem again using the new `optimize_budget` method. https://github.com/pymc-labs/pymc-marketing/blob/ccbd5a3ce454f370593804dfb061d6f1694db060/pymc_marketing/mmm/mmm.py#L2327 I have tried all possible `ftol` values (from 1e-9 to 1e9),...

MMM
optimizer

I've noticed that different ordering in DAG edges, even if `nx.DiGraph()` produces the same DAG, will provide different results for `self.adjustment_set` and `self.minimal_adjustment_set` https://github.com/pymc-labs/pymc-marketing/blob/06d1a34d5c03df7891c14dc4d333ed2668f9fc3a/pymc_marketing/mmm/causal.py#L115C22-L115C40 Not sure if this is something...

MMM
causal inference

**Describe the bug** `get_fast_api_app()` crashes when agent modules contain the new `App` class (introduced in ADK 1.14.0+) during graph visualisation with "ValueError: Unsupported tool type". **To Reproduce** Steps to reproduce...