Alexandre Gérault comments

Results 9 comments of


                                            Alexandre Gérault

doc(plugins): add help for type error about expect plugin

Maybe it would be better to also include the exact error message for SEO purpose (when pasting the error right into your search engine)? ``` Property 'expect' does not exist...

Error: Text content does not match server-rendered HTML.

I guess it's not enough to use the `/[lang]` as I end up with a 404. Maybe I've some configuration to do (I tried `http://localhost:3000/fr` and `http://localhost:3000/en`)

[11.x] Add typed getters for configuration

Thanks for the answer. I wonder how the contracts are breaking changes since I just added new methods 🤔 Is the contract used somewhere else?

[11.x] Add typed getters for configuration

I can but how do we make sure the contract would be updated on the next major release and won't be forgotten? Is that a good idea to merge without...

[11.x] Add typed getters for configuration

I think it's worth to have these methods, as we do for request. Nowadays we often tend to use static analysis tools to improve our codebase quality and spot bugs...

[11.x] Add typed getters for configuration

I just rebased the branch correctly so it doesn't include commits from 10.x 😅

[11.x] Add typed getters for configuration

> I think you can just drop the methods from the contract entirely and only put them on the repository. 👍 Also you need docblocks like the rest of the...

[11.x] Add typed getters for configuration

I think default values can be added on a next PR if that's not the moment 😄

Don't suggest Laravel Pest tests to be static functions

Yes, indeed the Pest function cannot be static since they internally rely on an actual class instance. Maybe you can get rid of these warning with a `$this` used in...