Alex Kovalevych
Alex Kovalevych
yeah, it would be nice to have, probably a separate `parse_stream` function
Thank you for your PR. It looks good, but can you please add a test for this case which will fail in master branch and pass in your branch?
@dmitrydprog thank you for your ticket, unfortunately i can't download the example file since that domain is not available from my country, please upload it to different storage (e.g. dropbox)
Well, i could reproduce it recently, but it doesn't look like a quick fix (unless you're very familiar with parsing algorithm). So i need to check the whole parsing process...
According to these tests everything works fine and the parser returns correct number of lines: https://github.com/AlexKovalevych/exoffice/blob/master/lib/exoffice.ex#L85 https://github.com/AlexKovalevych/exoffice/blob/master/lib/exoffice.ex#L140 Did i miss something?
> I can only say that the tests mentioned do not return the expected result for me So the tests are not passing on your machine? Since they passed on...
Could you please write a test or provide a test data for such cases?
Yup, but what's the deal with `test_rich_text.xls`, why it has changes?
Revert pls and i'll merge it
It would be nice to remove that dependency, but its used not only for UTF-16LE to UTF-8 conversion, e.g. https://github.com/AlexKovalevych/exoffice/blob/master/lib/exoffice/parser/excel_2003/string.ex#L72 Despite that, you can make a PR and we can...