Alberto Carreras

Results 19 comments of Alberto Carreras

@christianvuerings I wouldn't merge this until you're back. We disabled them cos they were causing many problems. Here's a list of issues I found working with them. - the error...

@EduhCosta You can use: https://github.com/pinterest/gestalt/blob/master/packages/gestalt-codemods/generic-codemods/modifyPropValue.js * CODEMOD to MODIFY (RENAME, ADD, OR REMOVE) PROP-VALUE COMBINATIONS in GESTALT COMPONENT * In the absence of nextProp+nextValue, the codemod removes the prop with...

Closing this as it's being stale for months.

Let's use TExt for styling ![Screenshot by Dropbox Capture](https://github.com/user-attachments/assets/f5973dcd-bfe9-4d6b-ad9e-11e7d08f99fe)

Check with Aaron what's the proper long string behavior, truncate?? wrap? center? start aligned? ![Screenshot by Dropbox Capture](https://github.com/user-attachments/assets/05321d04-f4e4-4461-b758-32fd2e2ed0c7)

Re accessibility ![Screenshot by Dropbox Capture](https://github.com/user-attachments/assets/178d70e3-1c9f-4729-af02-e3214595bfd5)

Fix this example ![Screenshot by Dropbox Capture](https://github.com/user-attachments/assets/055df30c-e208-4eef-b3de-457c626b0794)

whats the difference between iconColor white and light? can get the difference.

I think this PR is doing too much. You're changing several components APIs beyond your SideNavigation changes. I'd say we need onMouseEnter, onMouseLeave in all components if we decide we...

> @hectoid @AlbertCarreras I made a change that when nested item is selected, ots parent will always have border. This is how i understood the specs. If it's not something...