Alberic Liu
Alberic Liu
@kgyrtkirk does you mean if there is DISTINCT inside COUNT and useApproximateCountDistinct = true,then throw a CalciteContextException in SqlValidatorImpl, and describe the message like:" we should disable approx" the in...
@kgyrtkirk next time you can assign the task me, but this is good to learn as well.
@mustajibmk are you still working on this, i have similar work: https://github.com/apache/druid/pull/16024#issuecomment-1976131021, my bad, i did not know you have already work on this. if you do not work on...
@abhishekagarwal87 and @cryptoe may i continue to work on this, seems there is no response from 3 months ago. and i have a similar pr : https://github.com/apache/druid/pull/16024#issuecomment-1976131021 cc:@mustajibmk
> @AlbericByte , thanks for the changes. Please add an explanation of the approach you have taken in the PR description and also include a release note for the new...
@kfaraz @abhishekagarwal87 and @gianm for the failing test case, i have try sever times in my local environment using the latest code, it can successfully. do i need to increase...
hi @kfaraz @abhishekagarwal87 and @gianm Could you help to review this pr when you are not busy, i hope i can contribute more with your help.
> @AlbericByte Please create a new issue in [JIRA](https://issues.apache.org/jira/browse/CALCITE). add the jira in the description : CALCITE-6437 Thanks for notification
> In order to make it easier to keep track of the correspondence of issues in JIRA and github the issue title should match exactly the JIRA title. The commit...
> Please add a unit test that fails before the fix. The file SqlOperatorTest may be the right place for it. @mihaibudiu and @NobiGo added more test case, thanks for...