AlbanSagouis

In the middle of `split_decimal_degree` there is a call to `Rcpp::toString(x)` that takes `float& x `and turns it into `const std::string& x_str`. How would you do that without calling Rcpp?...

Rcpp::CharacterVector was silently converting user-provided numeric and integer values to character. Now the functions break when given numeric values.

Yes I think it is. - Why `paste0(x)` rather than `as.character(x)`? - Isn't that more costly than a C++ solution or banning numerical values? As a user, I do pass...

Seems to be a good place to me. Thanks! We are in the process of migrating from Rcpp to cpp11 so this might be something directly affected and if not,...

Ready to merge @mpadge Issues to solve when switching to cpp11: * Rcpp::DataFrame in `pz_split_llstr`, `pz_parse_parts_lat` & `pz_parse_parts_lon` * Returning NA values in `split_decimal_degree` instead of zeros

In this branch I kept old and new versions of many functions side by side in scripts (eg `pz_parse_lat` and `pz_parse_lat_old`). I used this to benchmark the effects of the...

> > In this branch I kept old and new versions of many functions side by side in scripts (eg `pz_parse_lat` and `pz_parse_lat_old`). I used this to benchmark the effects...

Thanks for the answer Will. So I tried `unzip(suppdata("10.1002/ece3.1456", 1))` on a Linux virtual machine and it works as expected so system seems indeed to be a critical aspect of...

Well, it works with `download.file()`. ``` > temp.file download.file("https://onlinelibrary.wiley.com/action/downloadSupplement?doi=10.1002%2Fece3.1456&file=ECE31456-sup-0001-suppl_data.zip", + temp.file) trying URL 'https://onlinelibrary.wiley.com/action/downloadSupplement?doi=10.1002%2Fece3.1456&file=ECE31456-sup-0001-suppl_data.zip' Content type 'application/zip; charset=UTF-8' length 391767 bytes (382 KB) downloaded 382 KB > is.data.frame(readxl::read_xls(unzip(temp.file)[2], 2, skip...

The fix did not solve the issue for me but I'll keep it in mind for future uses of `suppdata` And thanks for putting effort in trying to solve it....