Daniel

Results 22 comments of Daniel

since this repo seems to be abandoned i created an updated package which includes some of the here available pull requests, hop over to [@harmonyhub](https://github.com/AirBorne04/harmonyhub) and give it a try.

> So it sounds like the problem isn't actually that lit-ssr is depending on commonjs modules, it's that we're depending on built-in node modules? > > We don't do this...

Just made the suggested change @oddcelot and the styling issue is gone.

@RonenEizen for me it started to work also in the `global.d.ts` when changing the `/// ` to `import "@solidjs/start/env";` (make sure to restart ts server to see the effect) I...

I think I got to the bottom of the behaviour, it is described [here ambient vs augmented modules](https://www.typescriptlang.org/docs/handbook/modules/reference.html#ambient-modules). Just adding an `export {}` is fixing the issue but seems weird...

@ryansolid i guess it would make sense to rework to namespace? i threw together the needed changes here #1469 -> than the new way to overwrite the `RequestEventLocals` would look...

@rmacfie I did a couple of tests to figure it out and I did not test the specific suggestion. Did you test this? From my understanding the problem has nothing...

@rmacfie can you share the test setup, i tried making the stated modifications but it does not work for me.

@rmacfie > > @rmacfie can you share the test setup, i tried making the stated modifications but it does not work for me. > > I made a proof of...

Hi @niklauslee the issue here is that the environment vars are not replaced at compile time. They are instead proxied to the request env vars at runtime (in cloudflare env),...