Andrew Aikman comments

Results 38 comments of


                                            Andrew Aikman

add_plugin always adds plugins as 'last-child' of target (CMSPLugin.move too)

This functionality is part of the CMS v4 milestone and a functioning example already exists,.

Is i18n get_current_language needed any more ?

Hi @stuaxo, Sure thing. I'll post it into the Slack channel and get it marked with a task todo.

Add COLLATE "C" into database table column cms_cmsplugin.path.

@goutnet I see that we have 2 options here, one is a migration merge in v4, the other is to first rollback this migration when installing v4. I personally prefer...

Fix linter workflow and improve workflow performance

@marksweb I'll base a PR into this PR that fixes the failures this week. :-) Thanks for adding this.

Fix linter workflow and improve workflow performance

@marksweb Can we use the pre-commit formatter that you were using on the other projects to auto resolve the issues raised for flake 8 rather than manually fixing them?

Use `refresh_from_db()` instead of self implemented `reload()` methods

@jrief Sounds sane to me, I would say that if tests don't exist for the refresh feature we should implement them. The original _reload and reload methods can be kept...

Apphooks should be loaded on unpublished pages

@yakky was this issue ever resolved or is it still pending. a solution?

Apphooks should be loaded on unpublished pages

@yakky OK, no problem, one to discuss on priority and plan for a fix.

Apphooks should be loaded on unpublished pages

Does anyone here want to open a PR with a proposed fix? Ideally with tests to prove disprove the functionality!

We're still using the removed SEND_BROKEN_LINK_EMAILS settings.

I imagine that this was resolved long ago due to the fact that this feature was deprecated in Dj 1.8 and we're now supporting 3.1.